Fix tolerations API placement and implementation#1552
Conversation
Move tolerations from ContainerSpec to OperatorSpec level since tolerations are deployment/pod-level configuration, not container-level. Changes: - Move Tolerations field from ContainerSpec to OperatorSpec in API types - Update override logic to use correct field path (opOvr.Tolerations) - Fix test cases to use OperatorSpec.Tolerations instead of ControllerManager.Tolerations - Fix YAML indentation in sample configuration This corrects the API design to follow Kubernetes conventions where tolerations are specified at the pod template level, not per container. Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/precommit-check |
|
@stuggi: Overrode contexts on behalf of stuggi: ci/prow/precommit-check DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
Bot
merged commit 93d695e
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr3 |
|
@stuggi: new pull request created: #1553 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Move tolerations from ContainerSpec to OperatorSpec level since tolerations are deployment/pod-level configuration, not container-level.
Changes:
This corrects the API design to follow Kubernetes conventions where tolerations are specified at the pod template level, not per container.
Jira: OSPRH-18693